Joseph Koshakow <koshy44@gmail.com> writes:
> I must have been doing something wrong because I tried again today and
> it worked fine. However, I go get a lot of changes like the following:
> - if TIMESTAMP_IS_NOBEGIN(dt2)
> - ereport(ERROR,
> -
> (errcode(ERRCODE_DATETIME_VALUE_OUT_OF_RANGE),
> - errmsg("timestamp out of
> range")));
> + if TIMESTAMP_IS_NOBEGIN
> + (dt2)
> + ereport(ERROR,
> +
> (errcode(ERRCODE_DATETIME_VALUE_OUT_OF_RANGE),
> + errmsg("timestamp out of
> range")));
> Should I keep these pgindent changes or keep it the way I have it?
Did you actually write "if TIMESTAMP_IS_NOBEGIN(dt2)" and not
"if (TIMESTAMP_IS_NOBEGIN(dt2))"? If the former, I'm not surprised
that pgindent gets confused. The parentheses are required by the
C standard. Your code might accidentally work because the macro
has parentheses internally, but call sites have no business
knowing that. For example, it would be completely legit to change
TIMESTAMP_IS_NOBEGIN to be a plain function, and then this would be
syntactically incorrect.
regards, tom lane
