Re: Decoding of (nearly) empty transactions and regression tests - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Decoding of (nearly) empty transactions and regression tests
Date
Msg-id 7913.1404052582@sss.pgh.pa.us
Whole thread Raw
In response to Decoding of (nearly) empty transactions and regression tests  (Andres Freund <andres@2ndquadrant.com>)
Responses Re: Decoding of (nearly) empty transactions and regression tests  (Andres Freund <andres@2ndquadrant.com>)
List pgsql-hackers
Andres Freund <andres@2ndquadrant.com> writes:
> Solution I)
> Change ReorderBufferCommit() to not call the begin()/commit() callbacks
> if no change() callback has been called. Technically that's trivial, but
> I don't think that'd end up being a better behaviour.

> Solution II)
> Disable autovacuum/analyze for the tables in the regression tests. We
> test vacuum explicitly, so we wouldn't loose too much test coverage.

> Solution III)
> Mark transactions that happen purely internally as such, using a
> xl_xact_commit->xinfo flag. Not particularly pretty and the most
> invasive of the solutions.

> I'm favoring II) so far... Other opinions?

You mean disable autovac only in the contrib/test_decoding check run,
right?  That's probably OK since it's tested in the main regression
runs.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Doing better at HINTing an appropriate column within errorMissingColumn()
Next
From: Andres Freund
Date:
Subject: Re: Decoding of (nearly) empty transactions and regression tests