Re: Logical replication timeout problem - Mailing list pgsql-hackers

From Euler Taveira
Subject Re: Logical replication timeout problem
Date
Msg-id 78d4b56b-f6a5-4260-90a6-9943e0e88ce6@www.fastmail.com
Whole thread Raw
In response to Re: Logical replication timeout problem  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: Logical replication timeout problem
List pgsql-hackers
On Mon, May 9, 2022, at 3:47 AM, Amit Kapila wrote:
Thanks. The patch LGTM. I'll push and back-patch this after the
current minor release is done unless there are more comments related
to this work.
Looks sane to me. (I only tested the HEAD version)

+   bool        end_xact = ctx->end_xact;

Do you really need a new variable here? It has the same name and the new one
isn't changed during the execution.

Does this issue deserve a test? A small wal_receiver_timeout. Although, I'm not
sure how stable the test will be.


--
Euler Taveira

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Mark all GUC variable as PGDLLIMPORT
Next
From: "Euler Taveira"
Date:
Subject: Re: 2022-05-12 release announcement draft