Re: postgres_fdw hint messages - Mailing list pgsql-hackers

From Tom Lane
Subject Re: postgres_fdw hint messages
Date
Msg-id 789102.1662073729@sss.pgh.pa.us
Whole thread Raw
In response to Re: postgres_fdw hint messages  (Nathan Bossart <nathandbossart@gmail.com>)
Responses Re: postgres_fdw hint messages
List pgsql-hackers
Nathan Bossart <nathandbossart@gmail.com> writes:
> On Fri, Aug 26, 2022 at 12:35:38PM -0400, Tom Lane wrote:
>> I vote for just dropping all these hints for now, while leaving the
>> door open for anyone who wants to write closest-match-offering code.

> Here is a quickly-hacked-together proof-of-concept for using Levenshtein
> distances to determine which option to include in the hint.  Would
> something like this suffice?  If so, I will work on polishing it up a bit.

Seems reasonable to me, but

(1) there probably needs to be some threshold of closeness, so we don't
offer "foobar" when the user wrote "huh"

(2) there are several places doing this now, and there will no doubt
be more later, so we need to try to abstract the logic so it can be
shared.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Junwang Zhao
Date:
Subject: Re: [PATCH v1] fix potential memory leak in untransformRelOptions
Next
From: samay sharma
Date:
Subject: Re: [RFC] building postgres with meson - v11