Re: Correct error message for end-of-recovery record TLI - Mailing list pgsql-hackers

From Bossart, Nathan
Subject Re: Correct error message for end-of-recovery record TLI
Date
Msg-id 76C7E992-8E9A-47A9-BD73-01588AD3C0E9@amazon.com
Whole thread Raw
In response to Re: Correct error message for end-of-recovery record TLI  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On 10/28/21, 12:52 PM, "Bossart, Nathan" <bossartn@amazon.com> wrote:
> On 10/28/21, 12:23 PM, "Robert Haas" <robertmhaas@gmail.com> wrote:
>> On Thu, Oct 28, 2021 at 8:59 AM Amul Sul <sulamul@gmail.com> wrote:
>>> In xlog_redo, for end-of-recovery case error message describes the
>>> record as a checkpoint record which seems to be incorrect; the
>>> attached patch corrects that.
>>
>> The analysis and patch appear correct to me.
>
> When I apply the patch, it changes the PANIC message in the
> XLOG_CHECKPOINT_ONLINE section, not the XLOG_END_OF_RECOVERY one.

But other than that, the change seems reasonable to me.

Nathan


pgsql-hackers by date:

Previous
From: "Bossart, Nathan"
Date:
Subject: Re: Correct error message for end-of-recovery record TLI
Next
From: Robert Haas
Date:
Subject: Re: Minimal logical decoding on standbys