Re: Query ID Calculation Fix for DISTINCT / ORDER BY and LIMIT / OFFSET - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Query ID Calculation Fix for DISTINCT / ORDER BY and LIMIT / OFFSET
Date
Msg-id 7660B369-CF3D-4914-881A-5A8F0558C85C@paquier.xyz
Whole thread Raw
In response to Re: Query ID Calculation Fix for DISTINCT / ORDER BY and LIMIT / OFFSET  (Sami Imseih <samimseih@gmail.com>)
Responses Re: Query ID Calculation Fix for DISTINCT / ORDER BY and LIMIT / OFFSET
List pgsql-hackers
> On Mar 14, 2025, at 8:15, Sami Imseih <samimseih@gmail.com> wrote:
>> FWIW, another idea I have on top of my mind is the addition of a
>> counter in JumbleState that we increment each time we enter
>> _jumbleNode(), then simply call JUMBLE_FIELD_SINGLE() after the
>> incrementation.  And we can rely on this counter to be unique each
>> time we jumble a node..
>
> With this approach, the author of the custom function will need
> to remember to increment the counter, right?

Actually, no. _jumbleNode() is the unique entry point we use when jumbling a sub-Node in a bigger Node structure, so
customfunctions don’t need to touch it. 

> Also, I am wondering what is the difference between appending an incrementing
> counter in JState vs just appending a constant for every node ( NULL
> or NOT NULL ) ?

Well, the problem is not NULL vs non-NULL, so..
—
Michael



pgsql-hackers by date:

Previous
From: Sungwoo Chang
Date:
Subject: dsm_registry: Add detach and destroy features
Next
From: Quan Zongliang
Date:
Subject: Re: Available disk space per tablespace