Re: Memoize ANTI and SEMI JOIN inner - Mailing list pgsql-hackers

From Andrei Lepikhov
Subject Re: Memoize ANTI and SEMI JOIN inner
Date
Msg-id 765bd69e-c8a8-4349-a10f-b394331ddae6@gmail.com
Whole thread Raw
In response to Memoize ANTI and SEMI JOIN inner  (Andrei Lepikhov <lepihov@gmail.com>)
List pgsql-hackers
On 2/7/2025 05:48, wenhui qiu wrote:
> HI
> 
>  > - if (!extra->inner_unique && (jointype == JOIN_SEMI ||
>  > - jointype == JOIN_ANTI))
>  > + if ((jointype == JOIN_SEMI || jointype == JOIN_ANTI) &&
>  > + !extra->inner_unique)
> To be nitpicky, this change is meant to align with the earlier comment 
> modifications to improve code readability, right? Everything else looks 
> good to me."
Yep, I also found only this flaw.
Comments looks clear to me, test is quite stable.

May be correct the line:
INSERT INTO tab_anti SELECT i%3, false FROM generate_series(1,100)i;
with a backspace or an 'AS' keyword?

-- 
regards, Andrei Lepikhov



pgsql-hackers by date:

Previous
From: Eduard Stefes
Date:
Subject: RE: [V2] Adding new CRC32C implementation for IBM S390X
Next
From: Bertrand Drouvot
Date:
Subject: Re: A assert failure when initdb with track_commit_timestamp=on