Re: [PATCHES] Automatically setting work_mem - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCHES] Automatically setting work_mem
Date
Msg-id 7589.1145726228@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCHES] Automatically setting work_mem  (Simon Riggs <simon@2ndquadrant.com>)
Responses Re: [PATCHES] Automatically setting work_mem
Re: [PATCHES] Automatically setting work_mem
List pgsql-hackers
Simon Riggs <simon@2ndquadrant.com> writes:
> I still do, for multi-user systems. Releasing unused memory from a large
> CREATE INDEX will allow that memory to be swapped out, even if the brk
> point can't be changed.

Say what?  It can get "swapped out" anyway, whether we free() it or not.

More to the point, though: I don't believe that the proposed patch is a
good idea --- it does not reduce the peak sortmem use, which I think is
the critical factor for a multiuser system, and what it does do is
reduce the locality of access to the sort temp file during the merge
phases.  That will definitely have some impact; maybe small, but some;
and I don't see where the benefit comes in.

            regards, tom lane

pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: TODO items..
Next
From: "Jim C. Nasby"
Date:
Subject: Re: [PATCHES] Automatically setting work_mem