Re: COPY planning - Mailing list pgsql-hackers

From Tom Lane
Subject Re: COPY planning
Date
Msg-id 7557.1442865691@sss.pgh.pa.us
Whole thread Raw
In response to COPY planning  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: COPY planning  (Stephen Frost <sfrost@snowman.net>)
List pgsql-hackers
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> I noticed that COPY calls planner() (this was introduced in 85188ab88).
> I think it should be calling pg_plan_query() instead.

+1 --- AFAICS, this is the *only* place that is going directly to
planner() without going through pg_plan_query(); other utility
functions such as CREATE TABLE AS do the latter.

As far as the patch goes, do copy.c's #include's need adjustment?
I'm wondering if optimizer/planner.h could be removed, in particular.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: LW_SHARED_MASK macro
Next
From: Alvaro Herrera
Date:
Subject: Re: Obsolete use of volatile in walsender.c, walreceiver.c, walreceiverfuncs.c?