Postgres Pro
Downloads
Home   >   mailing lists

Re: Tighten up a few overly lax regexes in pg_dump's tap tests - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Tighten up a few overly lax regexes in pg_dump's tap tests
Date
Msg-id 7555CA46-012B-44A3-9BC8-AF5DCB1A79BF@yesql.se
Whole thread Raw
In response to Re: Tighten up a few overly lax regexes in pg_dump's tap tests  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Tighten up a few overly lax regexes in pg_dump's tap tests  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Tree view 
> On 6 Feb 2019, at 09:39, Michael Paquier <michael@paquier.xyz> wrote:

> And done after checking the whole set.

I still think we should enforce one-or-more matching on the OWNER part as well,
since matching zero would be a syntax error.  There are more .* matches but
I’ve only touched the ones which match SQL, since there is a defined grammar to
rely on there.  The attached patch does that on top of your commit.

cheers ./daniel
Attachment

pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: pg11.1: dsa_area could not attach to segment
Next
From: Amit Langote
Date:
Subject: Re: Bogus lateral-reference-propagation logic increate_lateral_join_info