Re: [PATCH] Cleanup of GUC units code - Mailing list pgsql-hackers

From Korry Douglas
Subject Re: [PATCH] Cleanup of GUC units code
Date
Msg-id 752780DC-9ACA-4B93-9CCD-F53C90342377@enterprisedb.com
Whole thread Raw
In response to Re: [PATCH] Cleanup of GUC units code  (Andrew Sullivan <ajs@commandprompt.com>)
List pgsql-hackers
>> Settings in postgresql.conf are currently case-insensitive. Except
>> for the units.
>
> And, of course, filenames when you are using a case-sensitive
> filesystem.  Because these are things that are defined by some
> convention other than the ones the PGDG made up.  Since units fall
> into that category, it seems to me that we're stuck with using
> external conventions.


Just a thought... since there are very few (if any) places where a  
user would specify a variable in terms of bits (kilobits, megabits,  
gigabits), we could make the units case-insensitive and assume that  
kb, gb, and mb (and all case variants) refer to some number of bytes.   
If a user wants to specify a variable in terms of bits, he would have  
to spell out the units completely, as in "4 gigabits", "20 kilobits",  
or "16 megabits".

        -- Korry



pgsql-hackers by date:

Previous
From: Simon Riggs
Date:
Subject: Re: Synchronous Log Shipping Replication
Next
From: "David Rowley"
Date:
Subject: Re: [PATCHES] TODO item: Implement Boyer-Moore searching (First time hacker)