Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] Relcache leak when row triggers on partitions are firedby COPY - Mailing list pgsql-hackers

From Amit Langote
Subject Re: [HACKERS] Relcache leak when row triggers on partitions are firedby COPY
Date
Msg-id 75267993-08c4-3e55-242d-2142e9622699@lab.ntt.co.jp
Whole thread Raw
In response to Re: [HACKERS] Relcache leak when row triggers on partitions are firedby COPY  (Thomas Munro <thomas.munro@enterprisedb.com>)
Responses Re: [HACKERS] Relcache leak when row triggers on partitions are firedby COPY  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Tree view 
On 2017/05/16 10:03, Thomas Munro wrote:
> On Tue, May 16, 2017 at 12:32 PM, Amit Langote
> <Langote_Amit_f8@lab.ntt.co.jp> wrote:
>> I vote for ExecCleanupTriggerState(estate).  After your patch, there will
>> be 4 places, including afterTriggerInvokeEvents(), ExecEndPlan(), and
>> EvalPlanQualEnd(), that repeat the same block of code.
> 
> Ok, here's a patch like that.

Thanks, looks good to me.

>  The call to ExecCloseIndices() may
> technically be redundant (we never opened them).

Actually yes.  We never do ExecOpenIndices() on the ResultRelInfos
contained in es_trig_target_relations.

Thanks,
Amit

pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: [HACKERS] Server Crashes if try to provide slot_name='none' atthe time of creating subscription.
Next
From: Masahiko Sawada
Date:
Subject: [HACKERS] Obsolete sentence in CREATE SUBSCRIPTION docs