Re: Enhancing Memory Context Statistics Reporting - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Enhancing Memory Context Statistics Reporting
Date
Msg-id 74105887-E4EF-4CA2-9F0A-3C0CE05BF632@yesql.se
Whole thread Raw
In response to Re: Enhancing Memory Context Statistics Reporting  (Fujii Masao <masao.fujii@oss.nttdata.com>)
Responses Re: Enhancing Memory Context Statistics Reporting
List pgsql-hackers
> On 8 Apr 2025, at 18:41, Fujii Masao <masao.fujii@oss.nttdata.com> wrote:

> I noticed that the third argument of pg_get_process_memory_contexts() is named
> "retries" in pg_proc.dat, while the documentation refers to it as "timeout".

I've committed this patch as it was obviously correct, thanks!

> Also, as I mentioned earlier, I encountered an issue when calling
> pg_get_process_memory_contexts() on the PID of a backend that had just
> encountered an error but hadn't finished rolling back. It led to
> the following situation:

I reconfirmed that the bugfix that Rahila shared in [0] fixes this issue (and
will fix others like it, as it's not related to this patch in particular but is
a bug in DSM attaching).  My plan is to take that for a more thorough review
and test tomorrow and see how far it can be safely backpatched.  Thanks for
bringing this up, sorry about it getting a bit lost among all the emails.

--
Daniel Gustafsson

[0] CAH2L28shr0j3JE5V3CXDFmDH-agTSnh2V8pR23X0UhRMbDQD9Q@mail.gmail.com


pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: Remove unnecessary static type qualifiers
Next
From: Jacob Champion
Date:
Subject: Re: [PoC] Federated Authn/z with OAUTHBEARER