Re: [PATCH] test/ssl: rework the sslfiles Makefile target - Mailing list pgsql-hackers

From Jacob Champion
Subject Re: [PATCH] test/ssl: rework the sslfiles Makefile target
Date
Msg-id 7316398fbce3fdc0192c3b9c5aa1011e32e7f88e.camel@vmware.com
Whole thread Raw
In response to Re: [PATCH] test/ssl: rework the sslfiles Makefile target  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: [PATCH] test/ssl: rework the sslfiles Makefile target  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On Wed, 2021-07-28 at 23:09 +0200, Daniel Gustafsson wrote:
> > On 28 Jul 2021, at 23:02, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > Jacob Champion <pchampion@vmware.com> writes:
> > > As long as the .SECONDARYEXPANSION magic is clear enough to others, I'm
> > > happy.
> > 
> > After reading the gmake docs about that, I'd have to say it's likely to be next
> > door to unmaintainable.
> 
> Personally, I don’t think it’s that bad, but mileage varies.  It’s obviously a
> show-stopper if maintainers don’t feel comfortable with it.
> 
> > And, AFAICT, it's not in 3.80.
> 
> That however, is a very good point that I missed.  I think it’s a good tool,
> but probably not enough to bump the requirement.

No worries, it's easy enough to unroll the expansion manually. The
annoyances without secondary expansion are the duplicated lines for
each individual CA and the need to introduce .INTERMEDIATE targets so
that cleanup works as intended.

Attached is a v3 that does that, and introduces a fallback in case
openssl isn't on the PATH. I also missed a Makefile dependency on
cas.config the first time through, which has been fixed. The patch you
pulled out earlier is 0001 in the set.

--Jacob

Attachment

pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: Segment fault when excuting SPI function On PG with commit 41c6a5be
Next
From: Tom Lane
Date:
Subject: Re: Segment fault when excuting SPI function On PG with commit 41c6a5be