Re: [PATCH] test/ssl: rework the sslfiles Makefile target - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: [PATCH] test/ssl: rework the sslfiles Makefile target
Date
Msg-id FBD68F12-C591-4589-AAC7-38F16AD226CE@yesql.se
Whole thread Raw
In response to Re: [PATCH] test/ssl: rework the sslfiles Makefile target  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [PATCH] test/ssl: rework the sslfiles Makefile target
List pgsql-hackers
> On 28 Jul 2021, at 23:02, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Jacob Champion <pchampion@vmware.com> writes:

>> As long as the .SECONDARYEXPANSION magic is clear enough to others, I'm
>> happy.
>
> After reading the gmake docs about that, I'd have to say it's likely to be next
> door to unmaintainable.


Personally, I don’t think it’s that bad, but mileage varies.  It’s obviously a
show-stopper if maintainers don’t feel comfortable with it.

> And, AFAICT, it's not in 3.80.

That however, is a very good point that I missed.  I think it’s a good tool,
but probably not enough to bump the requirement.

--
Daniel Gustafsson        https://vmware.com/




pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCH] test/ssl: rework the sslfiles Makefile target
Next
From: Tom Lane
Date:
Subject: Re: Out-of-memory error reports in libpq