Re: [PATCH] test/ssl: rework the sslfiles Makefile target - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [PATCH] test/ssl: rework the sslfiles Makefile target
Date
Msg-id YRIpT6S+malaw79H@paquier.xyz
Whole thread Raw
In response to Re: [PATCH] test/ssl: rework the sslfiles Makefile target  (Jacob Champion <pchampion@vmware.com>)
Responses Re: [PATCH] test/ssl: rework the sslfiles Makefile target  (Daniel Gustafsson <daniel@yesql.se>)
Re: [PATCH] test/ssl: rework the sslfiles Makefile target  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Fri, Jul 30, 2021 at 03:11:49PM +0000, Jacob Champion wrote:
> No worries, it's easy enough to unroll the expansion manually. The
> annoyances without secondary expansion are the duplicated lines for
> each individual CA and the need to introduce .INTERMEDIATE targets so
> that cleanup works as intended.
>
> Attached is a v3 that does that, and introduces a fallback in case
> openssl isn't on the PATH. I also missed a Makefile dependency on
> cas.config the first time through, which has been fixed. The patch you
> pulled out earlier is 0001 in the set.

Patch 0001 is a good cleanup.  Daniel, are you planning to apply that?

Regarding 0002, I am not sure.  Even if this reduces a lot of
duplication, which is really nice, enforcing .SECONDARY to not trigger
with a change impacting Makefile.global.in does not sound very
appealing to me in the long-run, TBH.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Segment fault when excuting SPI function On PG with commit 41c6a5be
Next
From: Michael Meskes
Date:
Subject: Re: ECPG bug fix: DECALRE STATEMENT and DEALLOCATE, DESCRIBE