Re: Some architectures need "signed char" declarations - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Some architectures need "signed char" declarations
Date
Msg-id 7313.1010589877@sss.pgh.pa.us
Whole thread Raw
In response to Re: Some architectures need "signed char" declarations  (Doug McNaught <doug@wireboard.com>)
List pgsql-hackers
Doug McNaught <doug@wireboard.com> writes:
> Hmmm, according to my knowledge of C, 'c' should be an int here, as
> EOF is guaranteed not to collide with any legal char value.

I agree with Doug: EOF is not supposed to be equal to any value of
'char', therefore changing the variables to signed char will merely
break something else.  Probably the variables should be int; are their
values coming from getc() or some such?  Will look at it.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: again on index usage
Next
From: Tom Lane
Date:
Subject: Re: Time as keyword