Re: Extending outfuncs support to utility statements - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Extending outfuncs support to utility statements
Date
Msg-id 729666.1679250130@sss.pgh.pa.us
Whole thread Raw
In response to Re: Extending outfuncs support to utility statements  (Alexander Lakhin <exclusion@gmail.com>)
List pgsql-hackers
Alexander Lakhin <exclusion@gmail.com> writes:
> Please look at the function _readA_Const() (introduced in a6bc33019), which fails on current master under valgrind:
> ...
> Here _readA_Const() performs:
>                  union ValUnion *tmp = nodeRead(NULL, 0);

>                  memcpy(&local_node->val, tmp, sizeof(*tmp));

> where sizeof(union ValUnion) = 16, but nodeRead()->makeInteger() produced Integer (sizeof(Integer) = 8).

Right, so we can't get away without a switch-on-value-type like the
other functions for A_Const have.  Will fix.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Melanie Plageman
Date:
Subject: Re: Should vacuum process config file reload more often
Next
From: Juan José Santamaría Flecha
Date:
Subject: Re: Fix fseek() detection of unseekable files on WIN32