Re: pg_upgrade: Improve invalid option handling - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: pg_upgrade: Improve invalid option handling
Date
Msg-id 722222fa-8a94-fb74-8d92-658b9bcdcec3@2ndquadrant.com
Whole thread Raw
In response to Re: pg_upgrade: Improve invalid option handling  (Masahiko Sawada <sawada.mshk@gmail.com>)
List pgsql-hackers
On 2019-06-13 14:30, Masahiko Sawada wrote:
> Why do we need to change pg_fatal() to fprintf() & exit()? It seems to
> me that we can still use pg_fatal() here since we write the message to
> stderr.

It just makes the output more consistent with other tools, e.g.,

old:

pg_upgrade: unrecognized option `--foo'

Try "pg_upgrade --help" for more information.
Failure, exiting

new:

pg_upgrade: unrecognized option `--foo'
Try "pg_upgrade --help" for more information.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Simon Riggs
Date:
Subject: Re: Converting NOT IN to anti-joins during planning
Next
From: Peter Eisentraut
Date:
Subject: Re: Update list of combining characters