Re: pgsql: Use JsonbIteratorToken consistently in automatic variable declar - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Use JsonbIteratorToken consistently in automatic variable declar
Date
Msg-id 722.1444658190@sss.pgh.pa.us
Whole thread Raw
In response to pgsql: Use JsonbIteratorToken consistently in automatic variable declar  (Noah Misch <noah@leadboat.com>)
Responses Re: pgsql: Use JsonbIteratorToken consistently in automatic variable declar
List pgsql-committers
Noah Misch <noah@leadboat.com> writes:
> Use JsonbIteratorToken consistently in automatic variable declarations.
> Many functions stored JsonbIteratorToken values in variables of other
> integer types.  Also, standardize order relative to other declarations.
> Expect compilers to generate the same code before and after this change.

FWIW, I think this sort of thing should get back-patched.  It's presumably
pretty low-risk, and if you don't do that, you've created a bunch of
points of failure for bug-fix back-patches.  In code as volatile as the
jsonb code has been, it's foolish not to try to keep the branches as much
in sync as we can.

            regards, tom lane


pgsql-committers by date:

Previous
From: Noah Misch
Date:
Subject: pgsql: Use JsonbIteratorToken consistently in automatic variable declar
Next
From: Noah Misch
Date:
Subject: pgsql: Use JsonbIteratorToken consistently in automatic variable declar