Re: pgsql: pg_upgrade: Fix inconsistency in memory freeing - Mailing list pgsql-committers

From Michael Paquier
Subject Re: pgsql: pg_upgrade: Fix inconsistency in memory freeing
Date
Msg-id 72173298-8CF2-489E-9549-27A224D30A3F@paquier.xyz
Whole thread Raw
In response to Re: pgsql: pg_upgrade: Fix inconsistency in memory freeing  (Jeff Davis <pgsql@j-davis.com>)
List pgsql-committers
On Mar 31, 2025, at 3:12, Jeff Davis <pgsql@j-davis.com> wrote:
> Why pg_strdup() the "NULL" at all in that case? Usually I see that done
> so that there doesn't need to be a conditional when freeing, but here
> there's a conditional anyway.
>
> Perhaps something like the attached?

This would work for me as well. I’m ok to take care of it at the beginning of next week, based on your suggestion.
--
Michael





pgsql-committers by date:

Previous
From: David Rowley
Date:
Subject: pgsql: Fix planner's failure to identify multiple hashable ScalarArrayO
Next
From: Melanie Plageman
Date:
Subject: pgsql: aio: Add errcontext for processing I/Os for another backend