On 2017/07/11 19:49, Ashutosh Bapat wrote:
> On Tue, Jul 4, 2017 at 9:51 AM, Amit Langote
> <Langote_Amit_f8@lab.ntt.co.jp> wrote:
>
>>
>> Attached updated patches.
>
> There's an extra "we" in
> + * Note that attachRel's OID is in this list. If it's partitioned, we
> + * we don't need to schedule it to be scanned (would be a noop anyway
>
> And some portions of the comment before find_all_inheritors() in
> ATExecAttachPartition() look duplicated in portions of the code that
> check constraints on the table being attached and each of its leaf
> partition.
>
> Other than that the patches look good to me.
Thanks for the review. Patch updated taking care of the comments.
Regards,
Amit
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers