Re: peripatus build failures.... - Mailing list pgsql-hackers

From Tom Lane
Subject Re: peripatus build failures....
Date
Msg-id 70174.1530919126@sss.pgh.pa.us
Whole thread Raw
In response to Re: peripatus build failures....  (Larry Rosenman <ler@lerctr.org>)
Responses Re: peripatus build failures....  (Larry Rosenman <ler@lerctr.org>)
List pgsql-hackers
Larry Rosenman <ler@lerctr.org> writes:
> On Fri, Jul 06, 2018 at 06:40:49PM -0400, Tom Lane wrote:
>> I do not like the "-Wl,-z,notext" thing at all.  It fails to explain
>> why things are working OK in v11/HEAD, which makes me think that it's
>> band-aiding something rather than really fixing it.

> Following the advice in the error message, the following ALSO fixes it
> (REL_10_STABLE):
> +override CFLAGS   := -fPIC

Yeah, I wondered about whether that wasn't a cleaner answer, but the same
problem remains: if we need that in src/port/, why don't all the branches
need it?  It would be unsurprising if we'd gained a requirement for -fPIC
somewhere along the line, but I don't entirely believe that we lost one.
So I'd still like to know when this changed.

            regards, tom lane


pgsql-hackers by date:

Previous
From: Larry Rosenman
Date:
Subject: Re: peripatus build failures....
Next
From: Alvaro Herrera
Date:
Subject: Re: no partition pruning when partitioning using array type