Re: peripatus build failures.... - Mailing list pgsql-hackers

From Larry Rosenman
Subject Re: peripatus build failures....
Date
Msg-id 20180706230536.foc3h7xcb3crih57@ler-imac.local
Whole thread Raw
In response to Re: peripatus build failures....  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: peripatus build failures....  (Larry Rosenman <ler@lerctr.org>)
Re: peripatus build failures....  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Fri, Jul 06, 2018 at 06:40:49PM -0400, Tom Lane wrote:
> Larry Rosenman <ler@lerctr.org> writes:
> > anyone want to look at this, or at least give me a clue on how to add
> > this to 10 & below?
>
> I do not like the "-Wl,-z,notext" thing at all.  It fails to explain
> why things are working OK in v11/HEAD, which makes me think that it's
> band-aiding something rather than really fixing it.
>
> Perhaps you could spend a bit of time with git bisect and find out
> which commit un-broke things?  That should help us narrow down the
> true explanation.
>
>             regards, tom lane

Following the advice in the error message, the following ALSO fixes it
(REL_10_STABLE):

borg.lerctr.org /home/ler/Git/postgresql/src/port $ git diff
diff --git a/src/port/Makefile b/src/port/Makefile
index 81f01b25bb..9ef00b3d54 100644
--- a/src/port/Makefile
+++ b/src/port/Makefile
@@ -28,6 +28,7 @@ top_builddir = ../..
 include $(top_builddir)/src/Makefile.global

 override CPPFLAGS := -I$(top_builddir)/src/port -DFRONTEND $(CPPFLAGS)
+override CFLAGS   := -fPIC
 LIBS += $(PTHREAD_LIBS)

 OBJS = $(LIBOBJS) $(PG_CRC32C_OBJS) chklocale.o erand48.o inet_net_ntop.o \
borg.lerctr.org /home/ler/Git/postgresql/src/port $

Is that more acceptable?
--
Larry Rosenman                     http://www.lerctr.org/~ler
Phone: +1 214-642-9640                 E-Mail: ler@lerctr.org
US Mail: 5708 Sabbia Drive, Round Rock, TX 78665-2106

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: peripatus build failures....
Next
From: Michael Paquier
Date:
Subject: Re: BUG #14999: pg_rewind corrupts control file global/pg_control