On Fri, Jul 06, 2018 at 06:05:36PM -0500, Larry Rosenman wrote:
> On Fri, Jul 06, 2018 at 06:40:49PM -0400, Tom Lane wrote:
> > Larry Rosenman <ler@lerctr.org> writes:
> > > anyone want to look at this, or at least give me a clue on how to add
> > > this to 10 & below?
> >
> > I do not like the "-Wl,-z,notext" thing at all. It fails to explain
> > why things are working OK in v11/HEAD, which makes me think that it's
> > band-aiding something rather than really fixing it.
> >
> > Perhaps you could spend a bit of time with git bisect and find out
> > which commit un-broke things? That should help us narrow down the
> > true explanation.
> >
> > regards, tom lane
>
> Following the advice in the error message, the following ALSO fixes it
> (REL_10_STABLE):
>
> borg.lerctr.org /home/ler/Git/postgresql/src/port $ git diff
> diff --git a/src/port/Makefile b/src/port/Makefile
> index 81f01b25bb..9ef00b3d54 100644
> --- a/src/port/Makefile
> +++ b/src/port/Makefile
> @@ -28,6 +28,7 @@ top_builddir = ../..
> include $(top_builddir)/src/Makefile.global
>
> override CPPFLAGS := -I$(top_builddir)/src/port -DFRONTEND $(CPPFLAGS)
> +override CFLAGS := -fPIC
> LIBS += $(PTHREAD_LIBS)
>
> OBJS = $(LIBOBJS) $(PG_CRC32C_OBJS) chklocale.o erand48.o inet_net_ntop.o \
> borg.lerctr.org /home/ler/Git/postgresql/src/port $
>
> Is that more acceptable?
Err, add a $(CFLAGS) to the end of the added line.
> --
> Larry Rosenman http://www.lerctr.org/~ler
> Phone: +1 214-642-9640 E-Mail: ler@lerctr.org
> US Mail: 5708 Sabbia Drive, Round Rock, TX 78665-2106
--
Larry Rosenman http://www.lerctr.org/~ler
Phone: +1 214-642-9640 E-Mail: ler@lerctr.org
US Mail: 5708 Sabbia Drive, Round Rock, TX 78665-2106
