Re: Add test module for Custom WAL Resource Manager feature - Mailing list pgsql-hackers

From Jeff Davis
Subject Re: Add test module for Custom WAL Resource Manager feature
Date
Msg-id 6efdc29d57914e7bbd05a878f8c1813a18a8559e.camel@j-davis.com
Whole thread Raw
In response to Re: Add test module for Custom WAL Resource Manager feature  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
Responses Re: Add test module for Custom WAL Resource Manager feature
List pgsql-hackers
On Mon, 2022-11-14 at 09:34 +0530, Bharath Rupireddy wrote:
> Thanks. I would like to keep it simple.
>
> I've added some more comments and attached v2 patch herewith. Please
> review.

Committed with some significant revisions (ae168c794f):

  * changed to insert a deterministic message, rather than a random
one, which allows more complete testing
  * fixed a couple bugs
  * used a static initializer for the RmgrData rather than memset,
which shows a better example

I also separately committed a patch to mark the argument of
RegisterCustomRmgr as "const".


--
Jeff Davis
PostgreSQL Contributor Team - AWS





pgsql-hackers by date:

Previous
From: Jeff Davis
Date:
Subject: Re: allowing for control over SET ROLE
Next
From: Tom Lane
Date:
Subject: Re: Slow standby snapshot