Re: pgsql: Skip \password TAP test on old IPC::Run versions - Mailing list pgsql-committers

From Andrew Dunstan
Subject Re: pgsql: Skip \password TAP test on old IPC::Run versions
Date
Msg-id 6d880ea2-f8ca-f458-4dcd-a7a3e6d6cd7c@dunslane.net
Whole thread Raw
In response to pgsql: Skip \password TAP test on old IPC::Run versions  (Daniel Gustafsson <dgustafsson@postgresql.org>)
Responses Re: pgsql: Skip \password TAP test on old IPC::Run versions
List pgsql-committers


On 2023-04-08 Sa 09:57, Daniel Gustafsson wrote:
Skip \password TAP test on old IPC::Run versions

IPC::Run versions prior to 0.98 cause the interactive session to time out,
so SKIP the test in case these versions are detected (they are within the
base requirement for our TAP tests in general).  Error reported by the BF
and investigation by Tom Lane.

Discussion: https://postgr.es/m/414A86BD-986B-48A7-A1E4-EEBCE5AF08CB@yesql.se


Stylistic nitpick: It's not necessary to have 2 evals here:


+   skip "IO::Pty and IPC::Run >= 0.98 required", 1 unless
+       (eval { require IO::Pty; } && eval { $IPC::Run::VERSION >= '0.98' });


just say "eval { require IO::Pty; return $IPC::Run::VERSION >= '0.98'; }"


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

pgsql-committers by date:

Previous
From: Andrew Dunstan
Date:
Subject: pgsql: Try to unbreak MSVC builds for pg_waldump
Next
From: Tom Lane
Date:
Subject: pgsql: Improve indentation of multiline initialization expressions.