Re: meson: Non-feature feature options - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: meson: Non-feature feature options
Date
Msg-id 6d3310fb-50e3-34d8-fe10-8dd8c4ffdf23@enterprisedb.com
Whole thread Raw
In response to Re: meson: Non-feature feature options  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: meson: Non-feature feature options  (Nathan Bossart <nathandbossart@gmail.com>)
List pgsql-hackers
On 09.03.23 14:54, Daniel Gustafsson wrote:
>> On 9 Mar 2023, at 14:45, Peter Eisentraut <peter.eisentraut@enterprisedb.com> wrote:
> 
>> How about we just hardcode "openssl" here instead?  We could build that array dynamically, of course, but maybe we
leavethat until we actually have a need?
 
> 
> At least for 16 keeping it hardcoded is an entirely safe bet so +1 for leaving
> additional complexity for when needed.

I have committed it like this.

I didn't like the other variants, because they would cause the openssl 
line to stick out for purely implementation reasons (e.g., we don't have 
a line "compression: YES (lz4)".  If we get support for another ssl 
library, we can easily reconsider this.




pgsql-hackers by date:

Previous
From: Önder Kalacı
Date:
Subject: Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher
Next
From: Peter Eisentraut
Date:
Subject: Re: CI and test improvements