Re: cfbot run pgindent? - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: cfbot run pgindent?
Date
Msg-id 6b834dc2-ac96-6960-84c2-edaa341eb45d@2ndquadrant.com
Whole thread Raw
In response to cfbot run pgindent?  (Robbie Harwood <rharwood@redhat.com>)
Responses Re: cfbot run pgindent?  (Michael Paquier <michael@paquier.xyz>)
Re: cfbot run pgindent?  (Thomas Munro <thomas.munro@enterprisedb.com>)
List pgsql-hackers
On 18/12/2018 19:50, Robbie Harwood wrote:
> Second, since the project does have a defined style checker, do you
> think it would be possible to run it as part of cfbot and report errors?

pgindent is a code formatter, not a style checker.  Using it to check
whether just the newly added code is correctly formatted would probably
require that all existing code is correctly formatted at all times,
which isn't the case.

What cfbot could do is spit out a diff at the end between the current
code and the pgindent'ed version.  That might be useful in some cases.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: [HACKERS] CLUSTER command progress monitor
Next
From: Peter Eisentraut
Date:
Subject: WRITE_*_ARRAY macros for outfuncs.c