Re: cpluspluscheck vs ICU - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: cpluspluscheck vs ICU
Date
Msg-id 6af1ac53-c458-0e63-4d2d-ae77751d4340@dunslane.net
Whole thread Raw
In response to Re: cpluspluscheck vs ICU  (Andres Freund <andres@anarazel.de>)
Responses Re: cpluspluscheck vs ICU  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
On 3/22/22 22:23, Andres Freund wrote:
> Hi,
>
> On 2022-03-22 17:20:24 -0700, Andres Freund wrote:
>> I was about to propose adding headerscheck / cpluspluscheck to the CI file so
>> that cfbot can catch future issues.
> The attached patch does so, with ICU disabled to avoid the problems discussed
> in the thread. Example run:
> https://cirrus-ci.com/task/6326161696358400?logs=headers_headerscheck#L0
>
> Unless somebody sees a reason not to, I'm planning to commit this soon.
>

That only helps when running the CI/cfbot setup. Fixing it for other
(manual or buildfarm) users would be nice. Luckily crake isn't building
with ICU.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com




pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: logical decoding and replication of sequences
Next
From: Robert Haas
Date:
Subject: Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints