Re: pltcl valgrind output - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: pltcl valgrind output
Date
Msg-id 6ab18916-272a-e513-0405-9e92e90df3e4@2ndQuadrant.com
Whole thread Raw
In response to pltcl valgrind output  (Andrew Dunstan <andrew.dunstan@2ndquadrant.com>)
Responses Re: pltcl valgrind output  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers

On 12/18/2017 10:12 AM, Andrew Dunstan wrote:
> I've been adding support for valgrind to the buildfarm client (code will
> hit the git repo shortly). Mostly the results have been pretty clean,
> but the pltcl tests generated the attached output. Perhaps someone with
> more valgrind-fu than I have so far would like to use the information to
> extend our supp file appropriately (or fix what it's complaining about).


The following appears to keep valgrind quiet. AFAICT the problem isn't
in our code.

    diff --git a/src/tools/valgrind.supp b/src/tools/valgrind.supp
    index af03051..24c6f5b 100644
    --- a/src/tools/valgrind.supp
    +++ b/src/tools/valgrind.supp
    @@ -212,3 +212,11 @@
        Memcheck:Cond
        fun:PyObject_Realloc
     }
    +
    +#### issue with TclNRRunCallbacks
    +{
    +   tcl_callback
    +   Memcheck:Cond
    +   ...
    +   fun:TclNRRunCallbacks
    +}


cheers

andrew


-- 

Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Simone Gotti
Date:
Subject: Re: GSoC 2018
Next
From: Peter Eisentraut
Date:
Subject: Re: [HACKERS] Transaction control in procedures