Re: pure parsers and reentrant scanners - Mailing list pgsql-hackers

From Andreas Karlsson
Subject Re: pure parsers and reentrant scanners
Date
Msg-id 6a673976-59f6-4749-bc20-793547221804@proxel.se
Whole thread Raw
List pgsql-hackers
On 12/18/24 10:42 AM, Peter Eisentraut wrote:
> I can fix that with the attached patch.
> 
> The symbol YY_TYPEDEF_YY_SCANNER_T isn't documented, but we already use 
> it elsewhere in the code.
> 
> Note that in replication/syncrep.h and replication/walsender_private.h 
> we have to have an #ifndef wrapper because there are files that end up 
> including both headers.  Maybe we should put that #ifndef wrapper 
> everywhere for consistency?
> 
> Any thoughts?

Seems like a sane fix to me and as for the ifndef I have no strong 
opinion either way but I would personally probably have added it 
everywhere for consistency.

Andreas




pgsql-hackers by date:

Previous
From: Jeff Davis
Date:
Subject: Re: Add CASEFOLD() function.
Next
From: Jeff Davis
Date:
Subject: Re: Final result (display) collation?