On 07.12.24 20:29, Paul Jungwirth wrote:
> These five patches all look good to me.
>
> Note that my tests already include a section for REPLICA IDENTITY FULL,
> which passed. But the subscriber was using a SeqScan to look up tuples
> to update.
>
> Here are the steps (mostly just because it was confusing for me at
> first): First in FindUsableIndexForReplicaIdentityFull, we would call
> IsIndexUsableForReplicaIdentityFull, get back false, and decide there
> was no index to use. Then in FindReplTupleInLocalRel, localidxoid was 0,
> so we woudln't call IsIndexUsableForReplicaIdentityFull at all.
>
> After applying the five patches, I can see that we choose the index and
> call IsIndexUsableForReplicaIdentityFull from both sites. This should
> make applying changes a lot faster.
I have committed these. I will continue with reviewing v45-0002 and
following now.
