Re: [HACKERS] [PATCH]make pg_rewind to not copy useless WALfiles - Mailing list pgsql-hackers

From chenhj
Subject Re: [HACKERS] [PATCH]make pg_rewind to not copy useless WALfiles
Date
Msg-id 6a0c760d.a4b8.15eb9a6056d.Coremail.chjischj@163.com
Whole thread Raw
In response to Re: [HACKERS] [PATCH]make pg_rewind to not copy useless WAL files  (Alexander Korotkov <a.korotkov@postgrespro.ru>)
Responses Re: [HACKERS] [PATCH]make pg_rewind to not copy useless WAL files  (Alexander Korotkov <a.korotkov@postgrespro.ru>)
List pgsql-hackers
On 2017-09-23 01:59:0, "Alexander Korotkov" <a.korotkov@postgrespro.ru> wrote:
On Fri, Sep 22, 2017 at 7:16 PM, chenhj <chjischj@163.com> wrote:
This is the new pacth with TAP test and use Macro XLOGDIR.

Good.  I took a quick look over the patch.
Why do you need master_query(), standby_query() and run_query() in RewindTest.pm?
You can do just $node_master->safe_psql() and $node_slave->safe_psql() instead.

Ooh, i did not notice that function.Thank you for your advice!
 
---
Regards,
Chen Huajun
Attachment

pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: [HACKERS] [BUGS] BUG #14825: enum type: unsafe use?
Next
From: Robert Haas
Date:
Subject: Re: [HACKERS] CREATE COLLATION does not sanitize ICU's BCP 47language tags. Should it?