Re: BUG #15943: Valgrind-detected error in SlruPhysicalWritePage - Mailing list pgsql-bugs

From Andres Freund
Subject Re: BUG #15943: Valgrind-detected error in SlruPhysicalWritePage
Date
Msg-id 6F9C8AAA-D805-4E1D-8028-C9E1A1D8F0AB@anarazel.de
Whole thread Raw
In response to Re: BUG #15943: Valgrind-detected error in SlruPhysicalWritePage  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: BUG #15943: Valgrind-detected error in SlruPhysicalWritePage  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-bugs
Hi,

On August 8, 2019 12:43:32 PM EDT, Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
>On 2019-Aug-08, Alexander Lakhin wrote:
>
>> Indeed, "memset(&qe, 0, sizeof(qe));" added in the beginning of
>> asyncQueueAddEntries fixes the issue.
>> More interestingly, "memset(qe.data, 0, sizeof(qe.data));" in the
>same
>> place fixes it too (the patch is attached).
>
>Maybe VALGRIND_MAKE_MEM_DEFINED?

Seems there's no reason to not zero initialize memory here? But perhaps just by initializing the stack variable?
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.



pgsql-bugs by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: BUG #15943: Valgrind-detected error in SlruPhysicalWritePage
Next
From: Tom Lane
Date:
Subject: Re: BUG #15943: Valgrind-detected error in SlruPhysicalWritePage