Re: Amcheck: do rightlink verification with lock coupling - Mailing list pgsql-hackers

From Andrey M. Borodin
Subject Re: Amcheck: do rightlink verification with lock coupling
Date
Msg-id 6EFAA3E0-11FC-41D4-8649-3BBABA54EAB3@yandex-team.ru
Whole thread Raw
In response to Re: Amcheck: do rightlink verification with lock coupling  (Peter Geoghegan <pg@bowt.ie>)
Responses Re: Amcheck: do rightlink verification with lock coupling  (Peter Geoghegan <pg@bowt.ie>)
List pgsql-hackers

> 6 авг. 2020 г., в 04:25, Peter Geoghegan <pg@bowt.ie> написал(а):
>
> * Added _bt_checkpage() calls for buffers, as is standard practice in nbtree.
>
> * Added protection against locking the same page a second time in the
> event of a faulty sibling link -- we should avoid a self-deadlock in
> the event of a page that is corrupt in just the wrong way.
>
> * Updated obsolescent comments that claimed that we never couple
> buffer locks in amcheck.
Cool, thanks!
There's mintor typo: missing space in "of_bt_check_unique".

>
> I would like to commit something like this in the next day or two.
>
> Thoughts?

Sounds great! Thanks!

Best regards, Andrey Borodin.




pgsql-hackers by date:

Previous
From: vignesh C
Date:
Subject: Re: Parallel copy
Next
From: "Andrey M. Borodin"
Date:
Subject: Re: pg_rewind is not crash safe