Re: Changes for AIX buildfarm - Mailing list pgsql-patches

From Rocco Altier
Subject Re: Changes for AIX buildfarm
Date
Msg-id 6E0907A94904D94B99D7F387E08C4F5730EBB7@FALCON.INSIGHT
Whole thread Raw
In response to Changes for AIX buildfarm  ("Rocco Altier" <RoccoA@Routescape.com>)
List pgsql-patches
Attached is a patch for HEAD to implement Peter's suggestion to set the
SHLIB_LINK in the contrib modules that need it.

Also, this changes Makefile.aix to use SHLIB_LINK instead of LIBS so
that the changes to the contrib Makefiles are picked up correctly.
Further this makes it match more closely the link rules from
Makefile.shlib.

    -rocco

> -----Original Message-----
> From: Peter Eisentraut [mailto:peter_e@gmx.net]
> Sent: Wednesday, July 20, 2005 2:12 PM
> To: Rocco Altier
> Cc: pgsql-patches@postgresql.org; Tom Lane; Andrew Dunstan;
> Zeugswetter Andreas DAZ SD
> Subject: Re: [PATCHES] Changes for AIX buildfarm
>
>
> Tom Lane wrote:
> > Fair enough.  But I'm concerned about the proposed patch because it
> > seems to revert a deliberate change made some time ago:
> >
> >
> http://developer.postgresql.org/cvsweb.cgi/pgs>
ql/src/Makefile.shlib#r
> >ev1.65
> > http://archives.postgresql.org/pgsql-committers/2002-10/msg00054.php
> >
> > so I think we need more eyeballs on the problem before deciding this
> > is a good fix.
>
> A potentially more correct solution would be to set SHLIB_LINK in the
> makefiles of the affected modules only.  Certainly we don't want to
> link with all libraries all the time.
>
> --
> Peter Eisentraut
> http://developer.postgresql.org/~petere/
>

Attachment

pgsql-patches by date:

Previous
From: "Jim C. Nasby"
Date:
Subject: Re: [HACKERS] Patch to fix plpython on OS X
Next
From: Tom Lane
Date:
Subject: Re: Roles - SET ROLE Updated