sloppy handling of pointers - Mailing list pgsql-hackers

From Mark Dilger
Subject sloppy handling of pointers
Date
Msg-id 6C621856-6C9A-4598-90FF-0FF5BCB6E239@gmail.com
Whole thread Raw
Responses Re: sloppy handling of pointers  (Jim Nasby <Jim.Nasby@BlueTreble.com>)
List pgsql-hackers
rangetypes_spgist.c contains a call to detoast a pointer which was
just returned from a detoast operation.  This seems to do no harm,
but is to my mind a sloppy thinko.  Fix attached.

tsgistidx.c contains a detoast of a pointer where detoast of a datum
was likely intended.  Fix attached.

tsrank.c contains some arguably correct casts which I found slightly
less correct than an alternative that I've attached.  I'm pretty indifferent
on this one, and just as happy if it is not included.

Mark Dilger


Attachment

pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: make async slave to wait for lsn to be replayed
Next
From: "Tsunakawa, Takayuki"
Date:
Subject: Re: [RFC] Should we fix postmaster to avoid slow shutdown?