While going through below commit, few doubts/observations:
http://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=7f7485a0cde92aa4ba235a1ffe4dda0ca0b6cc9a
1. Bgworker.c - FindRegisteredWorkerBySlotNumber() { .. /* * Copy contents of
workerlist into shared memory. Record the * shared memory slot assigned to each worker. This ensures * a 1-to-1
correspondencebetwen the postmaster's private list and * the array in shared memory. */ ..
} a. Comment in function doesn't seem to be appropriate. It seems copy-pasted from function
BackgroundWorkerShmemInit b. all function's except this have function header to explain a bit about function, though
it might not be required here, but not sure so pointed.
2. Shouldn't function
do_start_bgworker()/StartOneBackgroundWorker(void) be moved to bgworker.c as similar functions
AutoVacWorkerMain()/PgArchiverMain()are in their respective files.
3. bgworker.h - file header still contains explanation only as per old functionality. Not sure, if it
needsto be updated for new functionality of dynamic workers.
With Regards,
Amit Kapila.
