Re: qsort vs MSVC build - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: qsort vs MSVC build
Date
Msg-id 6BCB9D8A16AC4241919521715F4D8BCEA0FC93@algol.sollentuna.se
Whole thread Raw
In response to Re: qsort vs MSVC build  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: qsort vs MSVC build  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
> > MSVCRTD.lib(MSVCR80D.dll) : error LNK2005: _qsort already
> defined in
> > qsort.obj
>
> Hmm.  I've been seeing related complaints on Darwin, but they
> were just warnings (about our qsort conflicting with the one in libc).

Yeah, seems it works in Mingw, but for some reason it's fatal in MSVC.


> Is it worth renaming our qsort to pg_qsort to avoid this?
> (I'd be inclined to do that via a macro "#define qsort
> pg_qsort", not by running around and changing all the code.)

Yeah, I think it is ;-) Just make sure it happens before we pull in
stdlib.h, so we don't rename tha tone as well...

//Magnus


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCHES] Adminpack build fix
Next
From: Martijn van Oosterhout
Date:
Subject: Re: qsort vs MSVC build