Re: [PATCHES] MSVC build broken (again) - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: [PATCHES] MSVC build broken (again)
Date
Msg-id 6BCB9D8A16AC4241919521715F4D8BCEA0FC1E@algol.sollentuna.se
Whole thread Raw
In response to Re: [PATCHES] MSVC build broken (again)  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
> >> Would it be possible to move the whole <crtdefs.h> block
> into win32.h?
>
> > Nope, it needs to go before <stdio.h> and friends, unfortunatly.
>
> OK, patch committed as-is then.  The whole thing still looks
> awfully icky though, particularly the way pg_config_os.h is
> included in one place for WIN32 and a different place everywhere else.
>
> Would it make sense to split win32.h into two files, one
> that's included in the normal pg_config_os.h place and one
> included after the system includes?

I've been looking at doing this before, but never got around to it. It's
a bit hairy, so it's definitly not something we want to do during beta,
though. But maybe for 8.3.

//Magnus


pgsql-hackers by date:

Previous
From: "Obe, Regina"
Date:
Subject: SQL:2003 Statistical functions - What are they?
Next
From: "Magnus Hagander"
Date:
Subject: Re: [PATCHES] vcbuild bison check