Bad bug in fopen() wrapper code - Mailing list pgsql-patches

From Magnus Hagander
Subject Bad bug in fopen() wrapper code
Date
Msg-id 6BCB9D8A16AC4241919521715F4D8BCEA0FBD3@algol.sollentuna.se
Whole thread Raw
Responses Re: Bad bug in fopen() wrapper code  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: Bad bug in fopen() wrapper code  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
There is a small bug in the fopen() wrapper code that was applied a
couple of weeks back for win32. It sets the wrong flags for files opened
in "append" mode. This makes the logfile writing not work - syslog.c
opens the logfile in append mode, but if the file does not already
exist, it will not be opened and an error is returned - causing the
postmaster to terminate.

This is pretty bad and pretty urgent - with this, systems installed by
the MSI installer simply *do not start*, because they are by default
configured to write logs to a file...

Attached patch sets the  O_CREAT option when appending to files.

//Ma <<open.diff>> gnus

Attachment

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: Timezone doc patch
Next
From: "Magnus Hagander"
Date:
Subject: pg_ctl error msg on Windows 2000