Re: [PATCHES] pg_strcasecmp in fe-connect.c - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: [PATCHES] pg_strcasecmp in fe-connect.c
Date
Msg-id 6BCB9D8A16AC4241919521715F4D8BCEA0FBA7@algol.sollentuna.se
Whole thread Raw
In response to Re: [PATCHES] pg_strcasecmp in fe-connect.c  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [PATCHES] pg_strcasecmp in fe-connect.c  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
> > This patch fixes a couple of cases where we use
> strcasecmp() instead
> > of
> > pg_strcasecmp() in fe_connect.c, coming from the LDAP client pathc.
>
> Applied.  I found another instance in contrib/hstore, too.

Ah. msvc builds don't currently build /contrib, that's why I missed that
one.

> There are also some occurrences in pgbench.c, but I'm unsure
> that we need be paranoid about changing those.


If we ever want to be able to compile it on a platform that doesn't have
strcasecmp() (such as MSVC++), we would, no?

//Magnus


pgsql-hackers by date:

Previous
From: "Nicolas Barbier"
Date:
Subject: Re: Optimize ORDER BY ... LIMIT
Next
From: "Magnus Hagander"
Date:
Subject: Re: [PATCHES] Tiny plpython fix