Re: windows / initdb oddness - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: windows / initdb oddness
Date
Msg-id 6BCB9D8A16AC4241919521715F4D8BCE6C8068@algol.sollentuna.se
Whole thread Raw
In response to windows / initdb oddness  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
> > Thinking about this a tiny bit more, it struck me that by
> far the best
> > way to do this is to stop using a magic argument and use the
> > environment instead. Then we don't need to mangle the
> command line at
> > all. This actually results in less code, and should be more robust
> > (mangling the command line in Windows is dangerous and
> difficult because of quotes).
>
> This seems like a good idea.
>
> Is there any reason to worry about an accidental environment conflict?
> If someone mistakenly did "export PG_RESTRICT_EXEC=1", it
> looks to me like this would cause the re-exec bit to be
> skipped, but I suppose the worst possible consequence is that
> the postmaster would refuse to start.
> Is there anything I don't see?  (Of course, the magic
> argument method can be broken manually in just the same way...)

This only affects initdb, not postmaster.

I don't see the risk being bigger with environment than commandline at
all.

//Magnus


pgsql-hackers by date:

Previous
From: Stephan Szabo
Date:
Subject: Re: pg_config, pg_service.conf, postgresql.conf ....
Next
From: "Magnus Hagander"
Date:
Subject: Re: windows / initdb oddness