Re: Home dir changes have broken MSVC builds - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: Home dir changes have broken MSVC builds
Date
Msg-id 6BCB9D8A16AC4241919521715F4D8BCE476533@algol.sollentuna.se
Whole thread Raw
In response to Home dir changes have broken MSVC builds  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: Home dir changes have broken MSVC builds
List pgsql-hackers
>Recent changes to interfaces/libpg/fe-connect.c have broken
>MSVC builds,
>which I am reliably informed are definitely still required - at least
>some uses of libpq.dll made with gcc apparently cause the resulting
>builds or applications to blow up.

Can you get some more specifics on that? We know it was a fact with
early betas because of the conflicting exports, but I was under the
impression that these issues were all fixed by now.
(not saying the MSVC build shouldn't work, just that the gcc should work
too...)


>The trouble seems to come from these 2 lines:
>
>+ #define _WIN32_IE 0x0400
>+ #include <shlobj.h>
>
>First, on MSVC, _WIN32_IE is already defined at that point. If you get
>around that then processing the include file causes errors.

Interesting - mingw was supposed to use compatible headers, I thought
:-)
Can you tru moving the #define up to the top of the file and see if that
fixes things? So it's pulled before *any* windows include file. (My msvc
has completely stopped building fromt he commandline. Need to fix that,
but it's not up right now)

//Magnus


pgsql-hackers by date:

Previous
From: Alin Vaida
Date:
Subject: Re: [PATCHES] Final call for translation updates
Next
From: Alvaro Herrera
Date:
Subject: Re: subqueries in check