Re: APC/socket fix (final?) - Mailing list pgsql-patches

From Magnus Hagander
Subject Re: APC/socket fix (final?)
Date
Msg-id 6BCB9D8A16AC4241919521715F4D8BCE34B5FA@algol.sollentuna.se
Whole thread Raw
In response to APC/socket fix (final?)  (Claudio Natoli <claudio.natoli@memetrics.com>)
List pgsql-patches
>> I don't think it's a good idea in general to redefine something as
>> fundamental as select, send, recv etc from libpq-fe.h (or
>files included
>> from there).
>
>Certainly not; the redefinition would have to be in files that are not
>part of the exported API.  However this is not difficult.
>port.h is not
>included by libpq-fe.h.

I just realised that. I read too many files in parallell and got the
idea that it was included in libpq-fe.h. My mistake, sorry.

Then yes, we probably want to get that thing done for libpq as well.
Though socket operations in APCs arne't exactly common, we know for a
fact that they can give you interesting and incorrect results :-)
Whatever method we choose should probably be applied to the frontend as
well, yes.

//Magnus

pgsql-patches by date:

Previous
From: "Magnus Hagander"
Date:
Subject: Re: APC/socket fix (final?)
Next
From: Tom Lane
Date:
Subject: Re: APC/socket fix (final?)