Re: win32 inode fix - Mailing list pgsql-patches

From Magnus Hagander
Subject Re: win32 inode fix
Date
Msg-id 6BCB9D8A16AC4241919521715F4D8BCE1715D6@algol.sollentuna.se
Whole thread Raw
In response to win32 inode fix  (Claudio Natoli <claudio.natoli@memetrics.com>)
Responses Re: win32 inode fix  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-patches
> Claudio Natoli <claudio.natoli@memetrics.com> writes:
> > Under Win32, stat() returns an st_ino field, but it has no
> meaning (on
> > Win2K, and possibly all Win32 variants, it is always 0).
>
> MSDN says:
>
>     Number of the information node (the inode) for the file
>     (UNIX-specific). On UNIX file systems, the inode describes the
>     file date and time stamps, permissions, and content. When files
>     are hard-linked to one another, they share the same inode. The
>     inode, and therefore st_ino, has no meaning in the FAT, HPFS, or
>     NTFS file systems.
>
> I wonder if this might return non-zero for some relatively
> rare Win32 filesystems (say, an NFS share mounted via MS
> Services For Unix). Perhaps it might be cleaner to consider a
> zero inode "unknown", and therefore not equal to anything else?

It still returns 0 on a NFS share mounted with SFU (just tested). My bet
is that it will always return 0.

Might still be cleaner to change the code to make "zero equals unknown".
Is there a risk of another filesystem om some platform that won't return
inode?

//mha

pgsql-patches by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: [HACKERS] dollar quoting
Next
From: "Mark Cave-Ayland"
Date:
Subject: Re: ANALYZE patch for review