Re: Non-superuser subscription owners - Mailing list pgsql-hackers

From Mark Dilger
Subject Re: Non-superuser subscription owners
Date
Msg-id 6BB4451E-7B1B-474C-BD1F-DB7531E720C6@enterprisedb.com
Whole thread Raw
In response to Re: Non-superuser subscription owners  (Mark Dilger <mark.dilger@enterprisedb.com>)
Responses Re: Non-superuser subscription owners
Re: Non-superuser subscription owners
Re: Non-superuser subscription owners
List pgsql-hackers

> On Nov 1, 2021, at 10:58 AM, Mark Dilger <mark.dilger@enterprisedb.com> wrote:
>
> ALTER SUBSCRIPTION..[ENABLE | DISABLE] do not synchronously start or stop subscription workers.  The ALTER command
updatesthe catalog's subenabled field, but workers only lazily respond to that.  Disabling and enabling the
subscriptionas part of the OWNER TO would not reliably accomplish anything. 

I have rethought my prior analysis.  The problem in the previous patch was that the subscription apply workers did not
checkfor a change in ownership the way they checked for other changes, instead only picking up the new ownership
informationwhen the worker restarted for some other reason.  This next patch set fixes that.  The application of a
changerecord may continue under the old ownership permissions when a concurrent command changes the ownership of the
subscription,but the worker will pick up the new permissions before applying the next record.  I think that is
consistentenough with reasonable expectations. 

The first two patches are virtually unchanged.  The third updates the behavior of the apply workers, and updates the
documentationto match. 


—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company




Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pg14 psql broke \d datname.nspname.relname
Next
From: Daniel Gustafsson
Date:
Subject: Re: remove internal support in pgcrypto?