Re: [HACKERS] Constifying numeric.c's local vars - Mailing list pgsql-hackers

From Andres Freund
Subject Re: [HACKERS] Constifying numeric.c's local vars
Date
Msg-id 69D966CB-83A7-46D3-BC8A-5B3A1A6B9ABF@anarazel.de
Whole thread Raw
In response to Re: [HACKERS] Constifying numeric.c's local vars  (Mark Dilger <hornschnorter@gmail.com>)
List pgsql-hackers

On February 21, 2018 8:49:51 AM PST, Mark Dilger <hornschnorter@gmail.com> wrote:
>
>The idea that set_var_from_var might be called on const_zero (or
>const_one,
>etc.) is not hypothetical.  It is being done in numeric.c.
>
>If this is safe, somebody needs to be a lot clearer about why that is
>so.  There
>are no comments explaining it in the file, and the conversation in this
>thread
>never got into any details about it either.

Just getting started for the day, no coffee yet. But, uh, what you're appear to be saying is that we have code
modifyingthe digits of the zero value? That's seems unlikely. 

Andres
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: missing toast table for pg_policy
Next
From: Mark Dilger
Date:
Subject: Re: [HACKERS] Constifying numeric.c's local vars