Re: BUG #9204: truncate_identifier may be called unnecessarily on escaped quoted identifiers - Mailing list pgsql-bugs

From Tom Lane
Subject Re: BUG #9204: truncate_identifier may be called unnecessarily on escaped quoted identifiers
Date
Msg-id 6917.1392313492@sss.pgh.pa.us
Whole thread Raw
In response to BUG #9204: truncate_identifier may be called unnecessarily on escaped quoted identifiers  (pythonesque@gmail.com)
Responses Re: BUG #9204: truncate_identifier may be called unnecessarily on escaped quoted identifiers
List pgsql-bugs
pythonesque@gmail.com writes:
> As in description.  This follows from how these are scanned in scan.l:

>     ident = litbuf_udeescape('\\', yyscanner);
> if (yyextra->literallen >= NAMEDATALEN)
> truncate_identifier(ident, yyextra->literallen, true);

Yeah, that's a bug --- yyextra->literallen is not the thing to use here.
It's just luck that truncate_identifier doesn't fail entirely, since
we're violating its API contract.  Will fix, thanks for reporting it.

            regards, tom lane

pgsql-bugs by date:

Previous
From: Tom Lane
Date:
Subject: Re: BUG #9198: psql -c 'SET; ...' not working
Next
From: Joshua Yanovski
Date:
Subject: Re: BUG #9204: truncate_identifier may be called unnecessarily on escaped quoted identifiers